Closing TBrowser in ROOT 6 generates crash

markhod · June 11, 2014, 12:25pm

Hello,

In ROOT 6 on OS X 10.9.3 opening a TBrowser and clicking the red close icon in top left corner consistently generates a crash on my 2008 macbook:

dyn223023:Desktop markhodgkinson$ root

Try ‘.help’, ‘.demo’, ‘.license’, ‘.credits’, ‘.quit’/’.q’

root [0] TBrowser m
(TBrowser &) @0x10a8470c0
root [1] root.exe(22257,0x7fff72391310) malloc: *** error for object 0x10a8470c0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
dyn223023:Desktop markhodgkinson$

Cheers,

Mark

couet · June 11, 2014, 12:44pm

With the same OSX, but with:

   ----------------------------------------------------------------
  | Welcome to ROOT 6.01/00                    http://root.cern.ch |
  |                                   (c) 1995-2014, The ROOT Team |
  | Built for macosx64                                             |
  | From heads/master@v6-00-00-144-gd030ed8, Jun 11 2014, 11:10:24 |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'     |
   ---------------------------------------------------------------

I do not get any crash:

root [0] TBrowser m
(TBrowser &) @0x10c5840b0
root [1]

markhod · June 11, 2014, 12:46pm

I’m not sure what you are saying - the only difference is your output says built from head on June 11 - do you think I need to update to the head? If not how can I diagnose the problem?

Thanks,

Mark

couet · June 11, 2014, 1:04pm

What I am saying is that, for me, the head is working on MacOSX. Can you try it ?

jfcaron · June 11, 2014, 5:59pm

I am also getting a crash when I close the TBrowser (clicking the red button) on OSX 10.9.2, using the ROOT 6.00.00 from MacPorts. The same happens when I use a “TBrowser Lite”.

I have attached the automatically generated report that is apparently sent to Apple. Maybe it is useful?

Jean-François
tbrowsercrash.txt (37.4 KB)

bellenot · June 12, 2014, 6:59am

Dear All,

This issue has been fixed in git master, and you can (most probably) avoid it by calling:

Instead of:

(i.e. creating the browser on the heap instead of on the stack)

Cheers, Bertrand.

markhod · June 12, 2014, 10:33am

ok thanks - will try the update as soon as aI have a spare moment

markhod · June 27, 2014, 1:12pm

Hello,

I updated to the master today and still see the same crash:

mark-hodgkinsons-macbook:root markhodgkinson$ root
   ---------------------------------------------------------------
  | Welcome to ROOT 6.00/00                   http://root.cern.ch |
  |                                  (c) 1995-2014, The ROOT Team |
  | Built for macosx64                                            |
  | From heads/master@v6-00-00-96-gaaf9b65, Jun 27 2014, 14:55:46 |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'    |
   ---------------------------------------------------------------

root [0] TBrowser m
(TBrowser &) @0x10830c0c0
root [1] root.exe(48099,0x7fff7c5aa310) malloc: *** error for object 0x10830c0c0: pointer being freed was not allocated
*** set a breakpoint in malloc_error_break to debug
mark-hodgkinsons-macbook:root markhodgkinson$

So it must be something different on my macbook if it works for others? Does anyone have an idea?

Exactly what I did is:

git checkout master

then checked I am on the master:

mark-hodgkinsons-macbook:root markhodgkinson$ git branch

master
v6-00-00
v6-00-01

and did “make” which compiled something, which suggests I did update to the current master and pickup new files. I am not that clear on how git works yet, so maybe I misunderstood something…

Cheers,

Mark

bellenot · June 27, 2014, 1:32pm

Hi,

Well, apparently you don’t really have the head:

[code][bellenot@bbslc6x64-dev master2]$ root

Try ‘.help’, ‘.demo’, ‘.license’, ‘.credits’, ‘.quit’/’.q’

root [0]
[/code]
Cheers, Bertrand.

markhod · June 27, 2014, 1:33pm

Do you know how I can get this?

Thanks!

Mark

bellenot · July 1, 2014, 1:32pm

Well, simply “git clone root.cern.ch/git/root.git”:

[code]C:\Users\bellenot\Temp\git>git clone http://root.cern.ch/git/root.git
Cloning into ‘root’…
remote: Counting objects: 442859, done.
remote: Compressing objects: 100% (116404/116404), done.
remote: Total 442859 (delta 328638), reused 433782 (delta 321407)R
Receiving objects: 100% (442859/442859), 422.29 MiB | 5.52 MiB/s, done.
Resolving deltas: 100% (328638/328638), done.
Checking out files: 100% (21979/21979), done.

C:\Users\bellenot\Temp\git>cd root

C:\Users\bellenot\Temp\git\root>git status

On branch master

nothing to commit, working directory clean

C:\Users\bellenot\Temp\git\root>git branch -a

master
remotes/origin/HEAD -> origin/master
remotes/origin/master
remotes/origin/v3-10-02-patches
remotes/origin/v4-00-08-patches
remotes/origin/v4-03-04-patches
remotes/origin/v4-04-02-patches
remotes/origin/v5-08-00-patches
remotes/origin/v5-10-00-patches
remotes/origin/v5-12-00-patches
remotes/origin/v5-13-04-patches
remotes/origin/v5-14-00-patches
remotes/origin/v5-18-00-patches
remotes/origin/v5-20-00-patches
remotes/origin/v5-22-00-patches
remotes/origin/v5-24-00-patches
remotes/origin/v5-26-00-patches
remotes/origin/v5-27-06-patches
remotes/origin/v5-28-00-patches
remotes/origin/v5-30-00-patches
remotes/origin/v5-32-00-patches
remotes/origin/v5-34-00-patches
[/code]
Cheers, Bertrand.

markhod · July 1, 2014, 1:34pm

[quote=“bellenot”]Well, simply “git clone root.cern.ch/git/root.git”:

[code]C:\Users\bellenot\Temp\git>git clone http://root.cern.ch/git/root.git
Cloning into ‘root’…
remote: Counting objects: 442859, done.
remote: Compressing objects: 100% (116404/116404), done.
remote: Total 442859 (delta 328638), reused 433782 (delta 321407)R
Receiving objects: 100% (442859/442859), 422.29 MiB | 5.52 MiB/s, done.
Resolving deltas: 100% (328638/328638), done.
Checking out files: 100% (21979/21979), done.

C:\Users\bellenot\Temp\git>cd root

C:\Users\bellenot\Temp\git\root>git status

On branch master

nothing to commit, working directory clean

C:\Users\bellenot\Temp\git\root>git branch -a

master
remotes/origin/HEAD -> origin/master
remotes/origin/master
remotes/origin/v3-10-02-patches
remotes/origin/v4-00-08-patches
remotes/origin/v4-03-04-patches
remotes/origin/v4-04-02-patches
remotes/origin/v5-08-00-patches
remotes/origin/v5-10-00-patches
remotes/origin/v5-12-00-patches
remotes/origin/v5-13-04-patches
remotes/origin/v5-14-00-patches
remotes/origin/v5-18-00-patches
remotes/origin/v5-20-00-patches
remotes/origin/v5-22-00-patches
remotes/origin/v5-24-00-patches
remotes/origin/v5-26-00-patches
remotes/origin/v5-27-06-patches
remotes/origin/v5-28-00-patches
remotes/origin/v5-30-00-patches
remotes/origin/v5-32-00-patches
remotes/origin/v5-34-00-patches
[/code]
Cheers, Bertrand.[/quote]

sorry for late reply. I think in the end it was perhaps “git fetch” that updated my local area, and then after a recompile I did not see the problem anymore

bellenot · July 1, 2014, 1:38pm

OK, Glad to see it works now.

Cheers, Bertrand.