Chi2 for Landau convoluted Gauss fit

Dear experts,

I am fitting a distribution with Landau-Gauss conv function in Roofit and would like to calculate the chi2 value of the fit. I managed to get some value using frame.chiSquare() method, but it seems the number is questionable.
Here is the snippet of the code:

    hist = f.Get(hn)
    nbins = hist.GetSize()-2

    # Get mean and standard deviation for Gauss - Landau initial parameterization                                                                                                                                                                                                         
    mean   = hist.GetMean()
    sigma  = hist.GetStdDev()

    ## Construct observable                                                                                                                                                                                                                                                               
    minX,maxX = hist.GetXaxis().GetBinLowEdge(1), hist.GetXaxis().GetBinUpEdge(nbins)
    t = RooRealVar("t","t", minX, maxX)

    ## Construct gauss(t,mg,sg)                                                                                                                                                                                                                                                           
    mg = RooRealVar ("Gauss - mean","mg",0)
    sg = RooRealVar ("Gauss - sigma","sg",sigma,0.1*sigma,5.*sigma)
    gauss = RooGaussian ("gauss","gauss",t,mg,sg)

    ## Construct landau(t,ml,sl)                                                                                                                                                                                                                                                          
    ml = RooRealVar ("Landau - mean","mean landau",mean,mean-sigma,mean+sigma)
    sl = RooRealVar ("Landau - sigma","sigma landau",0.04,0.,0.2)
    landau = RooLandau ("lx","lx",t,ml,sl)

    ## C o n s t r u c t   c o n v o l u t i o n   p d f                                                                                                                                                                                                                                  
    ## ---------------------------------------                                                                                                                                                                                                                                            

    ## Set #bins to be used for FFT sampling                                                                                                                                                                                                                                              

    ## Construct landau (x) gauss                                                                                                                                                                                                                                                         
    lxg = RooFFTConvPdf ("lxg","landau (X) gauss",t,landau,gauss)

    ## S a m p l e ,   f i t   a n d   p l o t   c o n v o l u t e d   p d f                                                                                                                                                                                                              
    ## ----------------------------------------------------------------------                                                                                                                                                                                                             

    tofit = RooDataHist("dh", "dh", RooArgList(t), hist) ;

    ## Fit lxg to data                                                                                                                                                                                                                                                                    

    ## Plot data, landau pdf, landau (X) gauss pdf                                                                                                                                                                                                                                        
    xframe = t.frame()
    xframe.GetXaxis().SetTitle('#DeltaE/#Deltax [MeV/mm]')

    ## Calculate chi2                                                                                                                                                                                                                                                                     
    chi2 = xframe.chiSquare(3)
    print 'chi2 =', chi2

I get a result of chi2 = 17.27, which I think is too big especially when looking at the fit result below.

When calling chiSquare I use nFitParam=3 considering 3 floating parameters of the fit = Gauss - sigma, Landau - mean, Landau - sigma. Is this correct?


Hi Yosse,

at first sight, what you do looks correct, also that you have three fit parameters. For the parameters, you can still check the fit result. Use something like

result = lxg.fitTo(tofit, ROOT.RooFit.Save())

to have the result saved and printed. It should list only the three parameters you mentioned.


to have the post-fit values in the plot.

What makes me think that Chi^2/ndf might actually be correct in this case is that at dE/dx = 2, the data seem to have tiny errors, but the curves don’t match. This might cause the high chi2 value.
Just to confirm, you can run the fit only from 0 to 1.8.

Is this a weighted dataset? Maybe the errors in the histogram are wrong?

Hi Stephan,

For the test, if I fit from 0 to 1.8 the fit failed, I can only go to 1.9, see below. Now it gives me chi2/NDF 515,5 :no_mouth:

I’m confident that the error is correct. It comes from a weighted fill. And the histogram is later normalized.
Correct me if I’m wrong, but the error does not come in the calculation anywhere right?

Correction :wink:
The error of the data points is retrieved in the function you linked (although it’s being symmetrised, which is not really correct for Poisson errors). To summarise: The error of the curve is ignored, the error of the data is taken into account.

A couple more things you should try / check:

Hi Stephan,

Thank you for the suggestion,
Please see my replies below:

  • The SumW2 is set when the histogram is filled with TH1D().SetDefaultSumw2()
  • RooFit fit and plot the error correctly, I have made sure with
    lxg.fitTo(tofit, RooFit.SumW2Error(kTRUE));

    tofit.plotOn(xframe, RooFit.DataError(RooAbsData.SumW2))
  • I have made the check and the result surprises me:
    lxgtf = lxg.asTF(RooArgList(t))
    print 'chi2_tf =', hist.Chisquare(lxgtf)

I got chi2_tf = 7.64658586955e+24
So I evaluate the TF at 1.0 to see what’s going on and I get 1218447713.22. Clearly not what I expected.


Oh, very weird. It looks like it is constructing the TF1 from unnormalised values. Does this also happen with

listWithT = ROOT.RooArgList(t)
setWithT = ROOT.RooArgSet(t)
lxg.asTF(listWithT, ROOT.RooArgSet(), setWithT)


Hi Stephan, sorry for the delay.

I think the right syntax is

lxg.asTF(ROOT.RooArgList(t), ROOT.RooArgList(), ROOT.RooArgSet(t))

But anyway, the chi2 indeed return something close to 17 (after division by NDF and normalization correction). Now I am convinced that the calculation is correct and it is the ‘knee’ of the distribution at de/dx=2.0 that causes the bad fit. Now I have to return to the drawing board to fix this.

Thanks a lot for the support,really appreciate it!


This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.