Hello, I’m trying to fill a TClonesArray, I’ve looked for a lot of examples, and now I don’t know where could be the error.
I get this error during compilig the attached macro:
/simulation.C:184:21: error:
expected a type
new(hits1[j]) Hits1(xDir,yDir,zDir);
^
/simulation.C:192:21: error:
expected a type
new(hits2[j]) Hits2(xDir,yDir,zDir);
^
Thank you for your help.
simulation.C (7.13 KB)
Try:
root-config --cxx --cflags -O2 -W -Wall -c simulation.C
See also:
http://root.cern.ch/root/html/TClonesArray.html
http://www.cplusplus.com/reference/std/new/operator%20new/
http://www.cplusplus.com/reference/std/new/operator%20new%5B%5D/
Note: both, “Hits1” and “Hits2”, should be class names, I believe (from the source code that you posted, it’s not clear where these classes are defined). That’s why the compiler “expected a type” in both these places.
Thanks for the reply. Now my macro’s compiling, but when I run it I obtains a Segmentation violation with this error (I’ll attach the new version of the macro):
[code]root [1] simulation()
Error in TClonesArray::SetClass: called with a null pointer
Error in TClonesArray::SetClass: called with a null pointer
Error in TTree::Bronch: TClonesArray with no class defined in branch: Hits1
Error in TTree::Bronch: TClonesArray with no class defined in branch: Hits2
Error in TClonesArray::operator[]: invalid class specified in TClonesArray ctor
*** Break *** segmentation violation
#5 0x00000001050dbf5b in TObject::TObject ()
#6 0x0000000106f4241e in Direction::Direction ()
#7 0x0000000106f423e3 in Direction::Direction ()
#8 0x0000000108659e80 in simulation ()
===========================================================[/code]
simulation.C (7.14 KB)
What was in the line “root [0]”?
It seems to me that CINT still does not know what “Hits1” and “Hits2” are (you need to create ROOT-CINT dictionary entries for both of these classes, if you want to have them in a “TClonesArray”, I believe -> lines 80 and 82 in your new “simulation.C” file need them).
This is the line root[0]:
root [0] .x compile.C
Info in <TUnixSystem::ACLiC>: creating shared library /Users/cheip/Dropbox/examTANS/exam/simulation/VertexSimulator_cxx.so
Info in <TUnixSystem::ACLiC>: creating shared library /Users/cheip/Dropbox/examTANS/exam/simulation/PMultiplicity_cxx.so
Info in <TUnixSystem::ACLiC>: creating shared library /Users/cheip/Dropbox/examTANS/exam/simulation/Direction_cxx.so
Info in <TUnixSystem::ACLiC>: creating shared library /Users/cheip/Dropbox/examTANS/exam/simulation/simulation_C.so
compile.C is attached.
compile.C (316 Bytes)
Try:
root [0] .x compile.C
root [1] .class Hits1
root [2] .class Hits2
If you do not get details of both classes, then you need to call “CompileMacro” for both of them (e.g. for “Hits1.cxx” and “Hits2.cxx”, or any other source code file that defines them).
Ok, now I’ve solved! Hits1 and Hits2 aren’t classes, I’ve changed the name in the TClonesArray declaration!
Thank you for your help!!! 
I assume you changed the lines 80 and 82 of your new “simulation.C” file (I guess you changed both, “Hits1” and “Hits2”, into “Direction” -> that was the change that you did in the first place, in order to get the source code “compiled”).
Note: these are not “TClonesArray declarations”. These are calls to the “TClonesArray constructor” (and you actually also “define” two new variables, “hits1” and “hits2”, in these lines -> you do not just “declare” them).
BTW. If you want to mark your topic as “[color=#00CC00]SOLVED[/color]”, you do not need to change its “[color=#425067]Subject:[/color]”. When you read your topic, you should see a small green button “[color=#00CC00]/[/color]” (called “Accept this answer”, next to “[color=#BF0000]EDIT[/color]”) which can mark this topic as “[color=#00CC00]SOLVED[/color]”.