Shadow warnings on MacOS (CLang) were never fixed?

ROOT
1

Please read tips for efficient and successful posting and posting code

Please fill also the fields below. Note that root -b -q will tell you this info, and starting from 6.28/06 upwards, you can call .forum bug from the ROOT prompt to pre-populate a topic.

ROOT Version: 6.12 through 6.36 (at least)
Platform: macOS
Compiler: Apple Clang

In Shadow warnings when compiling against ROOT (2019) @pcanal suggested modifications to the ROOT header files in order to avoid global vs. namespace shadow warnings on MacOS.

It would appear that these suggestions were never actually incorporated into ROOT. I was seeing these warnings with ROOT 6.12, that forum post was for ROOT 6.18, and I am now seeing exactly the same warnings with ROOT 6.36.06.

Is there a process for reporting this as an actual bug, so that it gets fixed in future versions of ROOT?

2

Hi Michael,
Yes, it seems the proposed solution did not get included into the code base.
Did you get a chance to verify that is solves the issue for 6.36.06?

You can find our issue tracker here

Happy New Year,
Lukas

4

I wrote myself a little sed script an shell driver for this (linked below), and processed the files under /opt/homebrew/include/root/. When I build my application library, I now get no shadow warnings from the ROOT files previous involved.

shadow-patching.sh
shadow-patching.sed

5

I also created GitHub issue #20790, linking back to the original 2019 post.

6

Thank you very much for verifying and creating the issue. If you could send a PR with the modified source files at Pull requests · root-project/root · GitHub, that would be the icing on the cake.