I’m updating some code to compile against ROOT 6.34.04 and I’ve had a little bit of a frustrating time with the docs as they seem to include depreciated classes and at least one reference which seems to be out of date. I’ve listed below a couple of examples that I’ve stumbled upon. Hopefully they are helpful for updating the docs.
The first is for RooArgSet:
This line implies that there is still a createIterator() function. This does not seem to be the case anymore (looking at the 6.32 release notes it was set to be removed in 6.34).
The second is RooNLLVar, and some others It still shows up in the docs: ROOT: RooNLLVar Class Reference as both the cxx and header files are in the src dir – there is also a RooNLLVarNew. Look back through release notes, it was announced to be removed in 6.34 in the 6.32 notes: ROOT Version 6.32 Release Notes . Having these in the source code / docs for 6.34+ is rather confusing. If they still need to be there, but are just not public. Then maybe a note at the top of the files could be added so that the docs page is clearer.
Best,
Jonathan
_ROOT Version: 6.34.00 via Docker rootproject/root:latest
_Platform: Ubuntu Compiler: Not Provided
sorry you had a hard time upgrading to ROOT 6.34.00!
I addressed your comments in this PR:
If you have more problems, please feel free to report them here or on GitHub. There might be things that are harder to figure out, but I hope not.
The reason why many classes were moved to the RooFit internals was that this gives us more flexibility to optimize RooFits performance. So I hope you will also benefit from that.